msokolov commented on code in PR #15357:
URL: https://github.com/apache/lucene/pull/15357#discussion_r2460945705
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -72,12 +76,8 @@ public class Lucene104ScalarQuantizedVectorsWriter extends
FlatVectorsWriter {
private final Lucene104ScalarQuantizedVectorScorer vectorsScorer;
private boolean finished;
- /**
- * Sole constructor
- *
- * @param vectorsScorer the scorer to use for scoring vectors
- */
- protected Lucene104ScalarQuantizedVectorsWriter(
+ /** Sole constructor */
+ public Lucene104ScalarQuantizedVectorsWriter(
Review Comment:
ok that is kind of a tautology - I will be like the 5-year-old here and ask
so why do we want the writer to be created and used by other classes outside of
Lucene104ScalarQuantizedVectorsFormat :) I really have no objection - just
curious what motivated this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
