msokolov commented on code in PR #15316:
URL: https://github.com/apache/lucene/pull/15316#discussion_r2417804702
##########
lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorsReader.java:
##########
@@ -40,21 +40,6 @@
*/
public abstract class FlatVectorsReader extends KnnVectorsReader implements
Accountable {
- /** Scorer for flat vectors */
- protected final FlatVectorsScorer vectorScorer;
-
- /** Sole constructor */
- protected FlatVectorsReader(FlatVectorsScorer vectorsScorer) {
- this.vectorScorer = vectorsScorer;
- }
-
- /**
- * @return the {@link FlatVectorsScorer} for this reader.
- */
- public FlatVectorsScorer getFlatVectorScorer() {
Review Comment:
yeah I guess, but ... is it important to remove? I guess I'm thinkning of a
case where a consumer wants to get a vector values and score against it to
implement something like rescoring/ranking -- isn't this something we'd want to
support? Or maybe I'm confused and this method is not needed for that use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
