msokolov commented on code in PR #15316:
URL: https://github.com/apache/lucene/pull/15316#discussion_r2416743282
##########
lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorsReader.java:
##########
@@ -40,21 +40,6 @@
*/
public abstract class FlatVectorsReader extends KnnVectorsReader implements
Accountable {
- /** Scorer for flat vectors */
- protected final FlatVectorsScorer vectorScorer;
-
- /** Sole constructor */
- protected FlatVectorsReader(FlatVectorsScorer vectorsScorer) {
- this.vectorScorer = vectorsScorer;
- }
-
- /**
- * @return the {@link FlatVectorsScorer} for this reader.
- */
- public FlatVectorsScorer getFlatVectorScorer() {
Review Comment:
This is a breaking change that can't be back-ported -- do we think nobody
would ever want to use this? Would we still provide the scorer for cases where
we want to score vectors externally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
