msokolov commented on PR #15233: URL: https://github.com/apache/lucene/pull/15233#issuecomment-3353669933
Yes, @msfroh, exactly -- I was concerned that the commit logic below was actually part of the test (maybe?) and was thinking to perturb it as little as possible. The test as it was would also test the case where there are some uncommitted updates that would be flushed when the reader is opened (I think), but if we add the explicit commit *after* indexing all the docs then this case will no longer be tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
