benwtrent commented on code in PR #15263:
URL: https://github.com/apache/lucene/pull/15263#discussion_r2391865840
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##########
@@ -1382,7 +1379,8 @@ public List<Impact> getImpacts(int level) {
return readImpacts(level1SerializedImpacts, level1Impacts);
}
}
- return DUMMY_IMPACTS;
+ // Max freq is 1 since freqs are not indexed
+ return DUMMY_IMPACTS_NO_FREQ;
Review Comment:
I am not sure about this, I think we should return `DUMMY_IMPACTS` from
within the `if (indexHasFreq)` predicate but return `DUMMY_IMPACTS_NO_FREQ` if
outside of that predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
