jpountz commented on issue #15178: URL: https://github.com/apache/lucene/issues/15178#issuecomment-3280279358
These classes are so simple that I wonder if we should duplicate the code instead? I know that code duplication has a bad reputation, but in such cases I like how it makes maintenance easier because you don't have to worry about potential impact on `FirstPassGroupingCollector` when making changes to `DocScoreEncoder`. This is what we do for codecs: even when the N+1 version of a codec shares 99% of its code with version N, we still duplicate the code so that they can evolve fully independently. `MaxScoreAccumulator` adds so little value on top of a `LongAccumulator` that we may even want to remove it and fix call sites to use a `LongAccumulator` directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
