gaobinlong opened a new issue, #15178:
URL: https://github.com/apache/lucene/issues/15178

   ### Description
   
   
[MaxScoreAccumulator](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java)
 and 
[DocScoreEncoder](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/DocScoreEncoder.java)
 are used when [setting min competitive 
score](https://github.com/apache/lucene/blob/15b8d54e1da75da236d07220eeb9ea3e9ae15224/lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java#L168),
 now they are declared as protected, but if we want to set min competitive 
score in 
[FirstPassGroupingCollector](https://github.com/apache/lucene/blob/main/lucene/grouping/src/java/org/apache/lucene/search/grouping/FirstPassGroupingCollector.java)
 or in 
[OpenSearch#CollapsingTopDocsCollector](https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/apache/lucene/search/grouping/CollapsingTopDocsCollector.java)
 for performance improvement, these two classes cannot be accessed, so I 
propose t
 o declare the two classes and their methods as public.
   
   If no concern about this, I will launch a PR for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to