cwperks commented on code in PR #15120:
URL: https://github.com/apache/lucene/pull/15120#discussion_r2298954182
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##########
@@ -4777,6 +4782,21 @@ private void abortOneMerge(MergePolicy.OneMerge merge)
throws IOException {
closeMergeReaders(merge, true, false);
}
+ /** Compute {@code estimatedMergeBytes} and {@code totalMergeBytes} for a
merge. */
+ void addEstimatedBytesToMerge(MergePolicy.OneMerge merge) throws IOException
{
Review Comment:
I tried to make it static, but I was not able to because it calls
`numDeletedDocs()` which is non-static. When I tried to make `numDeletedDocs()`
static I ran into other issues. I've been trying to contribute more to Lucene
lately, but still very much coming up to speed on the repo so opted to start
small. Do you know if `numDeletedDocs()` and any other methods it calls can be
changed to static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
