msokolov commented on PR #15120: URL: https://github.com/apache/lucene/pull/15120#issuecomment-3220901546
Lucene doesn't really separate unit tests from integration tests, because it doesn't ship a service. But you can write unit tests at different levels of abstraction. I think what you've done here (create an index, add some docs, trigger merges, check the output) is about what we'd expect. But if you want to also test the size estimation of merges kicked off by "internal" policies, maybe the best way is to use RandomIndexWriter, which will sometimes randomly kick off some merges of its own? TBH this isn't an area of the code I know super well, and I commented mostly to understand what was going on! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
