rmuir commented on code in PR #15116:
URL: https://github.com/apache/lucene/pull/15116#discussion_r2296037176
##########
lucene/core/src/java/org/apache/lucene/util/GroupVIntUtil.java:
##########
@@ -57,13 +59,44 @@ public static void readGroupVInts(DataInput in, int[] dst,
int limit) throws IOE
* @param offset the offset in the array to start storing ints.
*/
public static void readGroupVInt(DataInput in, int[] dst, int offset) throws
IOException {
+ readGroupVInt(true, in, dst, offset);
+ }
+
+ /** DO not use! Only visible for benchmarking purposes! */
+ public static void readGroupVInt$Baseline(DataInput in, int[] dst, int
offset)
+ throws IOException {
+ readGroupVInt(false, in, dst, offset);
+ }
+
+ private static void readGroupVInt(boolean optimized, DataInput in, int[]
dst, int offset)
+ throws IOException {
final int flag = in.readByte() & 0xFF;
final int n1Minus1 = flag >> 6;
final int n2Minus1 = (flag >> 4) & 0x03;
final int n3Minus1 = (flag >> 2) & 0x03;
final int n4Minus1 = flag & 0x03;
+ // if our DataInput implements RandomAccessInput for absolute access and
IndexInput for seeking,
+ // we use a branch-less implementation:
+ if (optimized && in instanceof RandomAccessInput rin && in instanceof
IndexInput iin) {
Review Comment:
yeah i dont want to fix any of this on this PR, it is just an idea. If we
clean up the types and remove the instanceof checks, it makes for cleaner code.
I was not really thinking about performance: we have a lot of
implementations of this compression today, and i'm worried some are just
theoretical and not really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
