uschindler commented on code in PR #15116:
URL: https://github.com/apache/lucene/pull/15116#discussion_r2295330240
##########
lucene/core/src/java/org/apache/lucene/util/GroupVIntUtil.java:
##########
@@ -57,13 +59,44 @@ public static void readGroupVInts(DataInput in, int[] dst,
int limit) throws IOE
* @param offset the offset in the array to start storing ints.
*/
public static void readGroupVInt(DataInput in, int[] dst, int offset) throws
IOException {
+ readGroupVInt(true, in, dst, offset);
+ }
+
+ /** DO not use! Only visible for benchmarking purposes! */
+ public static void readGroupVInt$Baseline(DataInput in, int[] dst, int
offset)
+ throws IOException {
+ readGroupVInt(false, in, dst, offset);
+ }
+
+ private static void readGroupVInt(boolean optimized, DataInput in, int[]
dst, int offset)
Review Comment:
It was not easy to implement the baseLine only in the benchamrk as it would
have been too much code duplication. I will think about a better way to
separate those. I also do not like the public `readGroupVInts$BaseLine()`
method in the class. It can't be pkg-private because benchmark is (in contrast
to tests) in separate package. And SharedSecrets is even more complicated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
