shubhamvishu commented on PR #15011: URL: https://github.com/apache/lucene/pull/15011#issuecomment-3214553506
@jpountz Thanks for the changes. It looks overall good to me. I just made 2 simple refactoring changes on top : 1) Moved `FilteredDocIdSetIterator` creation to a separate fn 2) Removed `BitSetAcceptDocs` to further simplify and merged it with `BitSetAcceptDocs`(with no overhead added and since it was not doing any actual work-more of a record kind). Let me know if looks good or feel free to revert any changes. I think this looks in good shape to be merged soon (if nobody has concerns)?. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
