jainankitk commented on PR #15047: URL: https://github.com/apache/lucene/pull/15047#issuecomment-3209166532
> If the method is visible the parameters are part of (semi-)public signature. Then they are "relevant". Ah, that's smart. Thanks for the explanation! While trying to understand this, I noticed quite a few occurrences of `@SuppressWarnings("unused")` which can be replaced with unnamed variable for 11.0 atleast. I will raise few PRs to address that. First of many of those - https://github.com/apache/lucene/pull/15102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org