uschindler commented on PR #15047: URL: https://github.com/apache/lucene/pull/15047#issuecomment-3200095386
Hi, sorry why did you backport the original PR at all. The usused variable was exactly added to suppress the warnings. In Java 24 there is the unnamed variable `_`, but in Java 21 the original code was much easier to read. Please revert this and the original PR and restore the state which was totally applicable for Java 21. The unused variable was just there for better readability and has no performance impacts as this is exception handling code only. After reverting please move the changes entry to 11.0 section. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
