rmuir commented on issue #15079:
URL: https://github.com/apache/lucene/issues/15079#issuecomment-3197473729

   @uschindler I think the inlining breaks because of @jpountz recent change to 
introduce "type pollution".
   
   Specifically this line:
   
   ```java
   // Use ByteBuffersDirectory instead of MMapDirectory to have multiple 
IndexInput sub-classes used by queries
   try (Directory dir = new ByteBuffersDirectory()) {
   ```
   
https://github.com/mikemccand/luceneutil/blob/ea81b5d7f6e36bb04ffe7212f7e7129f9f6edc16/src/main/perf/TypePolluter.java#L64-L65
   
   Now during indexing, as soon as 1GB file is encountered, MMapDirectory 
introduces a third implementation which makes everything go megamorphic.
   
   I'd suggest:
   * Remove the two IndexInput implementations in MMapDirectory: there's no 
longer a 32-bit ByteBuffer limit at play.
   * Fix ByteBuffersDirectory (or rename it?) to no longer use ByteBuffers 
either. This should remove another implementation: it can just be mmap over an 
anonymous mapping.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to