thecoop commented on PR #14977: URL: https://github.com/apache/lucene/pull/14977#issuecomment-3159903829
It's largely to get rid of the extra condition [here](https://github.com/apache/lucene/pull/14977/files#diff-450f73057a709e2b0cdd64f0bb918720ca76d71b84ead9b6818b1eac872f1640L234). The reason why _that_ is useful is so we can guarantee that the `finishMerge` method is always called, so the contract can be tighter on that method. The reason _that_ is useful is so the read advice always gets set back to what it was [here].(https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java#L279). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
