dweiss commented on code in PR #14977: URL: https://github.com/apache/lucene/pull/14977#discussion_r2255099334
########## lucene/test-framework/src/java/org/apache/lucene/tests/codecs/asserting/AssertingKnnVectorsFormat.java: ########## @@ -230,8 +230,7 @@ public Map<String, Long> getOffHeapByteSize(FieldInfo fieldInfo) { public void close() throws IOException { assert !mergeInstance; delegate.close(); - delegate.close(); Review Comment: Wasn't this double close call intentional (to ensure close can be called multiple times without side-effects, as per its interface contract)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org