thecoop commented on code in PR #14977:
URL: https://github.com/apache/lucene/pull/14977#discussion_r2306579645
##########
lucene/core/src/java/org/apache/lucene/index/SegmentMerger.java:
##########
@@ -225,7 +226,7 @@ private void mergeTerms(SegmentWriteState
segmentWriteState, SegmentReadState se
}
}
- public void mergeFieldInfos() {
+ private void mergeFieldInfos() {
Review Comment:
All the other merge methods were private, and from the git blame there is no
particular reason for this, so this is just some consolidation. I can revert it
if there's a possibility for calling this specific method elsewhere?
##########
lucene/core/src/java/org/apache/lucene/index/SegmentMerger.java:
##########
@@ -225,7 +226,7 @@ private void mergeTerms(SegmentWriteState
segmentWriteState, SegmentReadState se
}
}
- public void mergeFieldInfos() {
+ private void mergeFieldInfos() {
Review Comment:
All the other merge methods are private, and from the git blame there is no
particular reason for this, so this is just some consolidation. I can revert it
if there's a possibility for calling this specific method elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
