thecoop commented on code in PR #14973:
URL: https://github.com/apache/lucene/pull/14973#discussion_r2219086215
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/morph/GraphvizFormatter.java:
##########
@@ -51,7 +52,7 @@ public String finish() {
// Backtraces another incremental fragment:
public void onBacktrace(
- DictionaryProvider<T> dictProvider,
+ Function<TokenType, Dictionary<? extends T>> dictProvider,
Review Comment:
If they're private, then there's less reason to have a custom type,
especially if it'll only be used as a lambda. But if we want to keep specific
types for public methods, I can change these back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
