dweiss commented on code in PR #14973:
URL: https://github.com/apache/lucene/pull/14973#discussion_r2218791087
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/morph/GraphvizFormatter.java:
##########
@@ -51,7 +52,7 @@ public String finish() {
// Backtraces another incremental fragment:
public void onBacktrace(
- DictionaryProvider<T> dictProvider,
+ Function<TokenType, Dictionary<? extends T>> dictProvider,
Review Comment:
Hmm. Some of these are I'd say forced? Yes, you use a built-in class but the
signature gets much longer and less intuitive (compared to
DictionaryProvider<T> in this case). Sometimes introducing an explicit named
interface is for the reader's benefit, I'd say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
