HUSTERGS commented on PR #14806: URL: https://github.com/apache/lucene/pull/14806#issuecomment-3095570822
> Unfortunately this commit broke some of the tests. Here is a repro: Sorry about that, it seems the `docIDRunEnd()` can sometimes exceed the `max`, thus causes `AssertingBulkScorer` failed at line 83, then causes the thread leak: https://github.com/apache/lucene/blob/973183258d1e11fee88a84b2a40b5fe02f0c477d/lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingBulkScorer.java#L82-L84 I changed ```diff - upTo = exclApproximation.docIDRunEnd(); + upTo = Math.min(max, exclApproximation.docIDRunEnd()); ``` And the test can pass properly locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
