HUSTERGS commented on code in PR #14806:
URL: https://github.com/apache/lucene/pull/14806#discussion_r2154727636


##########
lucene/core/src/java/org/apache/lucene/search/ReqExclBulkScorer.java:
##########
@@ -57,7 +57,10 @@ public int score(LeafCollector collector, Bits acceptDocs, 
int min, int max) thr
         exclDoc = exclApproximation.advance(upTo);
       }
       if (exclDoc == upTo) {
-        if (exclTwoPhase == null || exclTwoPhase.matches()) {
+        if (exclTwoPhase == null) {
+          // from upTo to docIdRunEnd() are excluded, so we scored up to 
docIdRunEnd()
+          upTo = exclApproximation.docIDRunEnd();
+        } else if (exclTwoPhase.matches()) {

Review Comment:
   I think it's correct here, and I run lucene test locally, everything looks 
fine. What I'm concerned here is that only `DocValuesRangeIterator` implement 
it's own `docIdRunEnd` method for now, I'm not sure whether adding this will 
hurt the performance or not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to