jpountz commented on code in PR #14896: URL: https://github.com/apache/lucene/pull/14896#discussion_r2209674256
########## gradle/validation/forbidden-apis/non-standard/incubator-vector.txt: ########## @@ -18,3 +18,6 @@ jdk.incubator.vector.IntVector#expand(**) jdk.incubator.vector.ShortVector#expand(**) jdk.incubator.vector.LongVector#expand(**) jdk.incubator.vector.VectorOperators#EXPAND_BITS + +@defaultMessage Potentially slow on some CPUs, please check Constants.HAS_SVE and Constants.HAS_AVX2 Review Comment: What about adding a `HAS_FAST_MASK_CAST` constant? It would have the same value as `HAS_FAST_COMPRESS` but at least it would be obvious to callers of `VectorMask#cast` that it does the right thing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
