uschindler commented on code in PR #14896:
URL: https://github.com/apache/lucene/pull/14896#discussion_r2209416739
##########
gradle/validation/forbidden-apis/non-standard/incubator-vector.txt:
##########
@@ -18,3 +18,6 @@ jdk.incubator.vector.IntVector#expand(**)
jdk.incubator.vector.ShortVector#expand(**)
jdk.incubator.vector.LongVector#expand(**)
jdk.incubator.vector.VectorOperators#EXPAND_BITS
+
+@defaultMessage Potentially slow on some CPUs, please check Constants.HAS_SVE
and Constants.HAS_AVX2
Review Comment:
I still think this can be merged with the above section.
Constants.HAS_FAST_COMPRESS ist basically the same.
##########
lucene/core/src/java24/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -54,6 +55,11 @@ final class PanamaVectorUtilSupport implements
VectorUtilSupport {
// preferred vector sizes, which can be altered for testing
private static final VectorSpecies<Float> FLOAT_SPECIES;
+ private static final VectorSpecies<Double> DOUBLE_SPECIES =
+ PanamaVectorConstants.PREFERRED_DOUBLE_SPECIES;
+ // This create a vector species which we make sure have exact half bits of
DOUBLE_SPECIES
+ private static final VectorSpecies<Integer> INT_FOR_DOUBLE_SPECIES =
Review Comment:
I don't full understand this: Why do we not simply use PREFERRED_INT_SPECIES?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
