rmuir commented on PR #14896: URL: https://github.com/apache/lucene/pull/14896#issuecomment-3064195912
> To move this forward, I believe that we should try to add detection of `UseSVE` and AVX2 to `Constants.java`, then a `HAS_FAST_COMPRESS` constant (akin to `HAS_FAST_VECTOR_FMA`), and finally replace the check on the number of lanes in `PanamaVectorUtil` with a check on this new constant? +1: I like that idea, of having checks for each "feature". It makes this haphazard situation amenable to static analysis to prevent problems: I will separately look into that. Note, this PR also uses some other features such as VectorMask.cast() and so on, I don't know off the top of my head what cpu instructions they use. Maybe nothing scary/special, just dont know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
