rmuir commented on PR #14896: URL: https://github.com/apache/lucene/pull/14896#issuecomment-3042008402
> ( IMHO, It might be beneficial if we can figure out a way to enable those complex vectorized operations (of couse, not in this PR), without slowing down on machines that don’t support the underlying instructions (or where they are not enabled in the JVM), because there may be other places where we could benefit from vectorization ? ) We can try to improve it and make more checks available, but the developer has to remember to use them. e.g. we have `HAS_FAST_INTEGER_VECTORS` but nobody ever remembers to use it. I will clean that one up in a separate PR. In cases like this one, I'm afraid it gets no simpler: sve must be checked for on the arm and avx-512 likely should also be avoided too. avx-512 is a mess of smaller instruction sets and maybe doing this compress requires VBMI or VBMI2 or something (I haven't looked yet, this is just an example). So better to use 256-bit vectors only since openjdk has a basic avx2 algorithm. https://en.wikipedia.org/wiki/Advanced_Vector_Extensions#AVX-512_CPU_compatibility_table -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
