benwtrent commented on PR #14922: URL: https://github.com/apache/lucene/pull/14922#issuecomment-3063201270
So, this diff from main passes the new test added here and all others. Is this what you had in mind @gf2121 @jpountz ```diff diff --cc lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java index 1d64be1a928,4850092ff01..00000000000 --- a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java +++ b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java @@@ -473,8 -473,9 +473,10 @@@ public final class IndexedDISI extends @Override public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws IOException { - assert doc >= offset; - while (doc < upTo && method.intoBitSetWithinBlock(this, upTo, bitSet, offset) == false) { + assert doc >= offset : "offset=" + offset + " doc=" + doc; + int disiUpto = Math.min(upTo, bitSet.length() + offset); - while (doc < disiUpto && method.intoBitSetWithinBlock(this, disiUpto, bitSet, offset) == false) { ++ while (doc < disiUpto ++ && method.intoBitSetWithinBlock(this, disiUpto, bitSet, offset) == false) { readBlockHeader(); boolean found = method.advanceWithinBlock(this, block); assert found; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org