pmpailis commented on PR #14922: URL: https://github.com/apache/lucene/pull/14922#issuecomment-3052018809
I'm thinking a bit more about this and whether autocorrecting this might hide other potential issues. In practice if a caller provides an incorrect `upTo` or `offset`, we would try to autocorrect here and provide a best effort (i.e. not actually accounting for `upTo` bits, but instead just for `bitSize`). So even though we wouldn't be met with IOOB exceptions, there would most likely be other issues down the line. Maybe addressing this only when `upTo == NO_MORE_DOCS` , or directly to the source of the "problem" in `AbstractKnnVectorQuery` might be a more safe approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
