HUSTERGS commented on PR #14827:
URL: https://github.com/apache/lucene/pull/14827#issuecomment-3030054987
The change from `ulp(double)` to `ulp(float)` seems to help decrease the
p-value compared to previous benchmark result, it's great!
<details>
<summary> luceneutil </summary>
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
IntNRQ 48.58 (1.4%) 48.14
(2.0%) -0.9% ( -4% - 2%) 0.090
Prefix3 98.75 (3.5%) 97.99
(4.3%) -0.8% ( -8% - 7%) 0.534
CountOrMany 6.41 (2.2%) 6.36
(2.6%) -0.7% ( -5% - 4%) 0.328
TermTitleSort 70.07 (5.0%) 69.57
(5.6%) -0.7% ( -10% - 10%) 0.669
CountPhrase 3.28 (3.2%) 3.27
(3.5%) -0.5% ( -6% - 6%) 0.616
FilteredIntNRQ 48.13 (1.6%) 47.88
(2.0%) -0.5% ( -4% - 3%) 0.363
FilteredPrefix3 92.07 (3.5%) 91.63
(4.0%) -0.5% ( -7% - 7%) 0.685
CountTerm 6724.13 (5.8%) 6693.36
(6.7%) -0.5% ( -12% - 12%) 0.817
CountFilteredOrMany 6.08 (1.6%) 6.05
(2.3%) -0.4% ( -4% - 3%) 0.548
FilteredPhrase 12.62 (1.4%) 12.58
(2.1%) -0.3% ( -3% - 3%) 0.554
CountOrHighHigh 63.73 (2.0%) 63.52
(2.5%) -0.3% ( -4% - 4%) 0.647
CountFilteredOrHighHigh 25.24 (1.3%) 25.18
(1.8%) -0.3% ( -3% - 2%) 0.610
CountAndHighHigh 61.82 (1.5%) 61.66
(1.7%) -0.3% ( -3% - 2%) 0.607
CountFilteredIntNRQ 22.20 (2.1%) 22.15
(2.2%) -0.2% ( -4% - 4%) 0.728
CountFilteredOrHighMed 29.69 (1.4%) 29.62
(1.8%) -0.2% ( -3% - 3%) 0.647
FilteredTerm 87.59 (5.9%) 87.40
(6.6%) -0.2% ( -11% - 13%) 0.912
Respell 43.52 (2.0%) 43.45
(2.4%) -0.2% ( -4% - 4%) 0.816
TermDayOfYearSort 344.16 (1.8%) 343.61
(1.2%) -0.2% ( -3% - 2%) 0.745
CountFilteredPhrase 11.50 (2.4%) 11.49
(2.1%) -0.1% ( -4% - 4%) 0.866
CountOrHighMed 96.68 (2.5%) 96.57
(3.3%) -0.1% ( -5% - 5%) 0.899
FilteredAndStopWords 11.98 (4.2%) 11.97
(4.2%) -0.1% ( -8% - 8%) 0.954
FilteredOrHighHigh 18.06 (3.3%) 18.05
(3.7%) -0.1% ( -6% - 7%) 0.962
FilteredAndHighHigh 15.22 (4.0%) 15.22
(3.9%) -0.0% ( -7% - 8%) 0.971
FilteredOrHighMed 54.08 (4.6%) 54.06
(5.6%) -0.0% ( -9% - 10%) 0.982
SloppyPhrase 1.44 (4.8%) 1.44
(3.9%) 0.0% ( -8% - 9%) 0.982
CountAndHighMed 93.74 (1.9%) 93.80
(3.4%) 0.1% ( -5% - 5%) 0.943
Wildcard 58.08 (3.5%) 58.13
(3.6%) 0.1% ( -6% - 7%) 0.937
Phrase 9.83 (2.0%) 9.85
(2.3%) 0.1% ( -4% - 4%) 0.839
DismaxTerm 634.49 (4.5%) 635.53
(6.3%) 0.2% ( -10% - 11%) 0.924
FilteredOr3Terms 59.59 (4.2%) 59.72
(5.2%) 0.2% ( -8% - 10%) 0.884
Fuzzy2 45.18 (3.2%) 45.29
(3.2%) 0.3% ( -6% - 6%) 0.802
FilteredOr2Terms2StopWords 67.27 (6.2%) 67.45
(7.2%) 0.3% ( -12% - 14%) 0.901
FilteredAnd3Terms 131.54 (2.7%) 131.95
(3.3%) 0.3% ( -5% - 6%) 0.747
CombinedOrHighMed 28.71 (5.4%) 28.81
(5.7%) 0.4% ( -10% - 12%) 0.837
TermMonthSort 2460.88 (4.2%) 2470.76
(5.0%) 0.4% ( -8% - 10%) 0.784
AndMedOrHighHigh 20.92 (1.5%) 21.02
(2.1%) 0.5% ( -3% - 4%) 0.412
CombinedAndHighMed 29.00 (5.5%) 29.14
(5.6%) 0.5% ( -10% - 12%) 0.776
TermDTSort 190.27 (4.4%) 191.39
(5.1%) 0.6% ( -8% - 10%) 0.695
Term10K 584.68 (5.0%) 588.32
(6.6%) 0.6% ( -10% - 12%) 0.738
DismaxOrHighMed 66.04 (4.2%) 66.49
(4.3%) 0.7% ( -7% - 9%) 0.621
FilteredOrMany 5.09 (2.0%) 5.12
(3.0%) 0.7% ( -4% - 5%) 0.402
Fuzzy1 50.40 (4.2%) 50.76
(4.7%) 0.7% ( -7% - 10%) 0.613
Term1M 584.67 (4.9%) 589.05
(6.9%) 0.7% ( -10% - 13%) 0.694
CombinedTerm 14.72 (4.4%) 14.84
(4.6%) 0.8% ( -7% - 10%) 0.580
AndHighOrMedMed 18.29 (3.5%) 18.44
(2.2%) 0.8% ( -4% - 6%) 0.381
TermB1M1P 583.58 (5.0%) 588.67
(6.7%) 0.9% ( -10% - 13%) 0.643
FilteredOrStopWords 10.94 (2.8%) 11.04
(3.3%) 0.9% ( -5% - 7%) 0.347
CombinedAndHighHigh 7.19 (2.0%) 7.26
(2.9%) 0.9% ( -3% - 5%) 0.234
Term100 582.93 (5.0%) 588.80
(6.8%) 1.0% ( -10% - 13%) 0.594
TermB1M 583.60 (4.8%) 589.94
(6.6%) 1.1% ( -9% - 13%) 0.552
CombinedOrHighHigh 7.10 (3.1%) 7.17
(4.1%) 1.1% ( -5% - 8%) 0.341
IntSet 384.28 (3.5%) 388.53
(4.8%) 1.1% ( -6% - 9%) 0.404
IntervalsOrdered 2.93 (3.7%) 2.96
(3.4%) 1.1% ( -5% - 8%) 0.309
SpanNear 3.06 (4.8%) 3.09
(3.9%) 1.2% ( -7% - 10%) 0.397
Term 582.79 (5.0%) 589.71
(6.8%) 1.2% ( -10% - 13%) 0.528
DismaxOrHighHigh 45.65 (3.4%) 46.21
(3.1%) 1.2% ( -5% - 8%) 0.235
OrHighRare 117.32 (6.4%) 118.79
(7.2%) 1.2% ( -11% - 15%) 0.562
OrHighMed 90.35 (4.4%) 91.60
(4.7%) 1.4% ( -7% - 10%) 0.337
AndHighMed 68.62 (3.3%) 69.82
(3.9%) 1.7% ( -5% - 9%) 0.126
FilteredAndHighMed 44.21 (3.8%) 44.99
(3.5%) 1.8% ( -5% - 9%) 0.123
AndHighHigh 26.53 (2.8%) 27.08
(2.4%) 2.1% ( -3% - 7%) 0.012
OrHighHigh 25.43 (2.8%) 26.16
(2.4%) 2.8% ( -2% - 8%) 0.001
FilteredAnd2Terms2StopWords 74.67 (6.7%) 77.28
(6.8%) 3.5% ( -9% - 18%) 0.101
And2Terms2StopWords 73.37 (8.9%) 76.53
(9.4%) 4.3% ( -12% - 24%) 0.137
Or2Terms2StopWords 75.05 (8.1%) 78.52
(8.3%) 4.6% ( -10% - 22%) 0.075
And3Terms 85.24 (6.1%) 90.46
(4.3%) 6.1% ( -3% - 17%) 0.000
Or3Terms 77.07 (6.1%) 82.11
(3.9%) 6.5% ( -3% - 17%) 0.000
OrMany 5.44 (7.2%) 5.84
(3.9%) 7.3% ( -3% - 19%) 0.000
OrStopWords 9.49 (7.8%) 10.21
(4.0%) 7.6% ( -3% - 21%) 0.000
AndStopWords 8.90 (7.7%) 9.64
(3.0%) 8.4% ( -2% - 20%) 0.000
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
