HUSTERGS commented on code in PR #14827: URL: https://github.com/apache/lucene/pull/14827#discussion_r2181197645
########## lucene/core/src/test/org/apache/lucene/search/TestScorerUtil.java: ########## @@ -93,4 +94,20 @@ public void testLikelyImpactsEnum() throws IOException { } } } + + public void testMinRequiredScore() { + double maxRemainingScore = random().nextDouble(); + float minCompetitiveScore = random().nextFloat(); + int numScorers = random().nextInt(1, 10); + + double minRequiredScore = + ScorerUtil.minRequiredScore(maxRemainingScore, minCompetitiveScore, numScorers); Review Comment: I tried to assert it in a way that relies on the internal implemenation detail of this function, not sure whether it's accecptable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org