HUSTERGS commented on PR #14827:
URL: https://github.com/apache/lucene/pull/14827#issuecomment-3024635431
Sorry for the late reply.
I've digged a little bit into this problem, it seems the root cause is the
initial `double` -> `float` cast, so I changed it from float to double, and the
luceneutil do not complain about the hit count anymore.
The benchmark result under same setup is as follows:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
OrHighRare 120.94 (2.7%) 122.37
(1.9%) 1.2% ( -3% - 5%) 0.109
OrHighMed 90.74 (3.6%) 92.40
(2.8%) 1.8% ( -4% - 8%) 0.073
AndHighMed 69.64 (2.8%) 71.32
(2.1%) 2.4% ( -2% - 7%) 0.002
AndHighHigh 28.49 (2.4%) 29.29
(2.1%) 2.8% ( -1% - 7%) 0.000
OrHighHigh 26.83 (2.5%) 27.60
(1.9%) 2.9% ( -1% - 7%) 0.000
```
The while loop containing call to `Math.nextDown` doesn's seem to add much
overhead. I locally added some simple print over the iteration count of the
loop, they are almost entirely zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
