benwtrent commented on code in PR #14838:
URL: https://github.com/apache/lucene/pull/14838#discussion_r2162003447
##########
lucene/core/src/java/org/apache/lucene/search/PatienceKnnVectorQuery.java:
##########
@@ -123,8 +123,24 @@ public static PatienceKnnVectorQuery
fromSeededQuery(SeededKnnVectorQuery knnQue
knnQuery, DEFAULT_SATURATION_THRESHOLD, defaultPatience(knnQuery));
}
- PatienceKnnVectorQuery(
- AbstractKnnVectorQuery knnQuery, double saturationThreshold, int
patience) {
+ public PatienceKnnVectorQuery(
+ SeededKnnVectorQuery knnQuery, double saturationThreshold, int patience)
{
+ super(knnQuery.field, knnQuery.k, knnQuery.filter,
knnQuery.searchStrategy);
+ this.delegate = knnQuery;
+ this.saturationThreshold = saturationThreshold;
+ this.patience = patience;
+ }
Review Comment:
We should have one package private ctor for `AbstractKnnVectorQuery` that
the public ones reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
