gf2121 commented on PR #14771: URL: https://github.com/apache/lucene/pull/14771#issuecomment-2970364769
Thanks for contribution, I'm actually a bit confused on your description. According to the flame graph your provide, it seems like it is running default implementation of `Bits#applyMask`. But as far as i know `liveDocs` is mostly `FixedBits` (And your change is optimizing this case as well), and `FixedBits` has override `applyMask` to run bitset intersection? https://github.com/apache/lucene/blob/686ef91e15f6be22aa6d2d55335d0e5160636c6a/lucene/core/src/java/org/apache/lucene/util/FixedBits.java#L34-L36 Could you provide more context on how did you catch this flame graph and why your change helps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
