mikemccand commented on PR #14765: URL: https://github.com/apache/lucene/pull/14765#issuecomment-2959024448
> Local benchmarking shows almost no performance impact, but I can no longer see any ram estimate methods in the top methods given the CPU samples. Whoa, thank you for the quick PR @benwtrent! That's disappointing that there's no speedup on local benchmark, odd. I wonder if the nightly profiler (JFR) is somehow giving ghosts ... it should be async (no safepoint bias)? Or maybe it's an env/benchy difference and once we merge this we'll maybe see gains in the nightly benchy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
