benwtrent opened a new pull request, #14765: URL: https://github.com/apache/lucene/pull/14765
This makes OnHeapGraph builder RAM estimates much cheaper by incrementally updating the estimate as nodes are added to the NeighborArray. Local benchmarking shows almost no performance impact, but I can no longer see any ram estimate methods in the top methods given the CPU samples. One outstanding bit here is that `OnHeapGraph#graphRamBytesUsed` is only volatile. So, its not really threadsafe for estimates. However, from what I can tell, the only time we actually use this is during initial flush, and that is within a single thread anyways, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
