mkhludnev commented on issue #14565:
URL: https://github.com/apache/lucene/issues/14565#issuecomment-2918935566

   Hello @Jinny-Wang 
   Thanks for your contribution. 
   It it's still an option I vote for extending (changing) existing 
`ToChildBlockJoinQuery` with new behavior. 
    - existing FilterWeight subclass can just drag second child-side scorer and 
count and accept matching children. It reminds me TwoPhaseIterator idea, but 
I'm not sure if it's applicable here. Anyway, it's a kind of 
composition/delegation. 
    - those who need children query score, may use FunctionQuery for this, so 
we can keep this concern separate at cost of some query-time burden (of 
repeating child side query).
    - I'd prefer deeper test coverage for such logic. so, changing 
`ToChildBlockJoinQuery` let to inherit existing test cases.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to