rmuir commented on PR #14679: URL: https://github.com/apache/lucene/pull/14679#issuecomment-2896403654
Thank you! "bulkpostings 2.0" is looking really clean and non-invasive :) > I suspect it may be tempting in the future, because it enables further optimizations as @gf2121 showed in [#14679 (comment)](https://github.com/apache/lucene/pull/14679#discussion_r2093432298) (though let's see if it actually translates to speedups with luceneutil), and because `FeatureField` is a contributor to `SimScorer#score` polymorphism. We can discuss this more in a followup. Yes, thank you, I agree 100% to investigate it as followup: the additional speedup hinted at there seems promising. If we can proceed with caution there, it would help. For similarities in particular, correct formula can be difficult, and if you have to implement it twice, I have some concerns around correctness. At the very minimum we'd want to improve BaseSimilarityTestCase... For PostingsEnum/Scorer changes I have similar concerns about correctness, I think what's happening in Asserting is not enough to guarantee correctness? E.g. for the PostingsEnum one I would think about CheckIndex itself validating the new bulk API, BasePostingsFormatTestCase additions, and also TestDuelingCodecs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
