jpountz commented on PR #14679: URL: https://github.com/apache/lucene/pull/14679#issuecomment-2895700581
You are correct, no need for additional APIs on Similarity at this point, I removed it. I suspect it may be tempting in the future, because it enables further optimizations as @gf2121 showed in https://github.com/apache/lucene/pull/14679#discussion_r2093432298 (though let's see if it actually translates to speedups with luceneutil), and because `FeatureField` is a contributor to `SimScorer#score` polymorphism. We can discuss this more in a followup. I cleaned up the change, it's now ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
