gf2121 commented on code in PR #14552: URL: https://github.com/apache/lucene/pull/14552#discussion_r2075141914
########## lucene/core/src/java/org/apache/lucene/util/FixedBitSet.java: ########## @@ -45,11 +45,12 @@ public final class FixedBitSet extends BitSet { /** * If the given {@link FixedBitSet} is large enough to hold {@code numBits+1}, returns the given Review Comment: This method is typically called with pattern like: ``` FixedBitSet bits = FixedBitSet.ensureCapacity(bits, doc); bits.set(doc): ``` So the returned bitSet is required to hold 0(inclusive) to numBits(inclusive), which is `numBits+1` bits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org