gf2121 commented on code in PR #14552: URL: https://github.com/apache/lucene/pull/14552#discussion_r2074918206
########## lucene/core/src/java/org/apache/lucene/index/SingletonSortedNumericDocValues.java: ########## @@ -57,6 +58,16 @@ public int advance(int target) throws IOException { return in.advance(target); } + @Override + public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws IOException { + in.intoBitSet(upTo, bitSet, offset); + } + + @Override + public int docIDRunEnd() throws IOException { + return in.docIDRunEnd(); + } Review Comment: I filed https://github.com/apache/lucene/pull/14618 to cover `SingletonSortedNumericDocValues` and `SingletonSortedSetDocValues`. I think all these work that implement methods for wrappers could be avoided after https://github.com/apache/lucene/pull/14475. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org