gf2121 commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2771814782
I roughly implemented the idea. This is my first time forking a new codec, hopefully have not made too many mistakes :) A few thoughts during my refactoring: * I thought i only need to fork a `Lucene103BlockTreeTerms` to intersect with `Lucene101Postings`. But it seems challenging based on current API design. I have to fork the new `Lucene103Postings` as well. Maybe this is a point can be improved? * I'm not sure if it matters to make it a default codec or not in main, as main will not get released anyway? Default to main without backporting sounds good enough to me. If we stick not to make it default, maybe this codec should be moved into test / sandbox / codec module? It would be weird to see multiple codecs in a core module for contributors who don't have the context of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
