gf2121 commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2770173066
Thank you very much for all these careful, warm and helpful comments! > Are there any major items / blockers? I think I've addressed all of them (hopefully didn't miss any). > Do all Lucene tests pass if you force tests to use this in their Codec? The `Lucene90BlockTreeTermsWriter` is now used by default codec so tests should catch it easily. All lucene core tests passed. > Maybe beast things a bit (run nightly, increase TEST_ITERS, etc.) :) I've finished a round of `./gradlew :lucene:core:test -Ptests.nightly=true -Ptests.monster=true` and all tests passed. I'll run more. > Once we think this is ready, we should prolly merge at first as the non-default Codec, and let CI chew on things / let it bake for a while in main? If all goes well, then maybe at some point we backport and make it default for a 10.x? I understand the idea that merge it into main but not backport immediately. But i do not know how to make CI catch this change and test it heavily without making it a default codec in main? Or you are meaning not backport to 10.x, but make it a default codec in main? (Sorry for my pool English!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
