gf2121 commented on code in PR #14359:
URL: https://github.com/apache/lucene/pull/14359#discussion_r2010115706


##########
lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java:
##########
@@ -238,9 +296,79 @@ private void scoreWindowUsingBitSet(
     windowMatches.clear();
   }
 
+  private void scoreWindowUsingLeapFrog(

Review Comment:
   Can we make this static?



##########
lucene/core/src/java/org/apache/lucene/search/DocValuesRangeIterator.java:
##########
@@ -210,6 +210,14 @@ public final boolean matches() throws IOException {
     };
   }
 
+  @Override
+  public int docIDRunEnd() throws IOException {

Review Comment:
   Do we have/need any tests against this implementation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to