jpountz commented on code in PR #14359:
URL: https://github.com/apache/lucene/pull/14359#discussion_r1998546217
##########
lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java:
##########
@@ -238,9 +296,77 @@ private void scoreWindowUsingBitSet(
windowMatches.clear();
}
+ private void scoreWindowUsingLeapFrog(
Review Comment:
The contract is that `TwoPhaseIterator#matches()` verifies if the current
doc ID of the approximation matches. So we cannot load matches from the
approximation into a bit set and then call `matches()` as it wouldn't check the
correct doc ID. We could change the API, but I'm not sure if that would buy
anything as our most typical two-phase iterator, PhraseQuery, is similar:
`PostingsEnum#nextPosition()` reads the next position of the current doc ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
