jainankitk commented on PR #14370: URL: https://github.com/apache/lucene/pull/14370#issuecomment-2737366662
> Eh, I am not sold that this change needs to occur if ever. While, "this is how its always been" isn't a good argument for some things, I think expanding the public, and then backwards compatible API needs careful consideration. I agree with @benwtrent. That's why I had below comment in [the original issue](https://github.com/apache/lucene/issues/14367): _Really minor at this point, and probably not worth going through the pain of deprecating IndexReader#leaves and changing at few hundred places_ Additionally, I don't think this change really addresses the confusion being called out in https://github.com/apache/lucene/issues/14367. Ideally, the default behavior of `IndexReader#leaves` should be what is being achieved here via `IndexReader#leafReaders`, and there should be more explicit method called `IndexReader#leafReaderContexts` for what `IndexReader#leaves` is doing today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
