mikemccand commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2711223110
> > Net/net I think we ought to be adding some multithreaded test capability to KnnGraphTester. > > Agreed, I think a "num_search_threads" parameter would be beneficial. Then the searcher that is created can have a fixed executor `ExecutorService executorService = num_search_threads > 1 ? Executors.newFixedThreadPool(num_search_threads) : null;` passed to it in `testSearch`. > > ``` > IndexSearcher searcher = new IndexSearcher(reader, executorService); > ``` I opened https://github.com/mikemccand/luceneutil/issues/350 to enable intra-query concurrency for KNN benchy, but +1 to making sure we report total CPU ticks (aggregated across all threads that participated for each query) in addition to "wall clock latency". Both metrics are useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
