msokolov commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2704319560
Another wrinkle here is that KnngraphTester currently does not ever run its queries multithreaded; it does not pass an Executor when it creates IndexSearcher. Because of that we are not truly testing the behavior of the existing AbstractKnnVectorQuery, that can potentially behave differently when run multithreaded, possibly consuming more total CPU and even yielding different results, because in the single-threaded case where each segment is searched in succession, the threshold derived from prior segments is used when searching the successor segments, but when searched concurrently, information propagates *while* searching, so some prospective unnecessary searching may be happening, and for all we know, may be yielding some additional matches too. Net/net I think we ought to be adding some multithreaded test capability to KnnGraphTester. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
