kaivalnp commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2697320627
Summary of latest changes: 1. Added tests! These will only run if `libfaiss_c.so` (along with all dependencies) is present during runtime (in `$LD_LIBRARY_PATH` or `-Djava.library.path`) 2. The minimum Java version was recently [bumped](https://github.com/apache/lucene/commit/32a0c95c00551bcd91a85c1e673976539257a73b) to 23 on `main`, which simplifies this PR -- we no longer need an `apijar` and MR-JAR changes 3. Faiss distances are now scaled to Lucene scores 4. Added some javadocs and misc refactors With this, I think the PR is ready for review! (I don't see any major blockers / TODOs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
