iverase opened a new pull request, #14249: URL: https://github.com/apache/lucene/pull/14249
In https://github.com/apache/lucene/pull/12770 we refine how we were searching the graph by only considering nodes that were making the values of the score better, basically the condition in line 290 become `friendSimilarity > minAcceptedSimilarity`. In #14215, to improve the termination check and avoid edge cases when having many duplicated vectors, we change how we compute the minAcceptedSimilarity to `Math.nextUp(results.minCompetitiveSimilarity())`. Because we didn't change the first condition, now we are not considering nodes where `friendSimilarity == minAcceptedSimilarity` although those nodes will have better score? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
