rmuir opened a new pull request, #14248: URL: https://github.com/apache/lucene/pull/14248
TestRegExpParsing assertions about regexes: that the internal parse tree matches an expected structure, and then that resulting automaton is the correct language. In cases where a DFA is expected, we assert that it is `isDeterministic()`. In cases where an NFA is expected, there is currently just a code comment in the test. Replace calls to `isDeterministic()` with `assertMinimalDFA()` if the parser should give minimal output. Use `assertCleanDFA()` and `assertCleanNFA()` otherwise to ensure that automaton has no dead states, and if appropriate, is deterministic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org